Good catch. Will fix them in the next iteration.
Thanks.
Chandra
On Tue, 2011-10-18 at 07:16 +0200, Arkadiusz Miśkiewicz wrote:
> On Tuesday 18 of October 2011, Chandra Seetharaman wrote:
>
> Quick look for diff between your and mine patch when I was playing with
> separate project quota some time ago and:
>
> > diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c
> > index 5cc3dde..3a67805 100644
> > --- a/fs/xfs/xfs_qm_syscalls.c
> > +++ b/fs/xfs/xfs_qm_syscalls.c
> > @@ -120,11 +120,11 @@ xfs_qm_scall_quotaoff(
> > }
> > if (flags & XFS_GQUOTA_ACCT) {
> > dqtype |= XFS_QMOPT_GQUOTA;
> > - flags |= (XFS_OQUOTA_CHKD | XFS_OQUOTA_ENFD);
> > + flags |= (XFS_GQUOTA_CHKD | XFS_GQUOTA_ENFD);
> > inactivate_flags |= XFS_GQUOTA_ACTIVE;
> > } else if (flags & XFS_PQUOTA_ACCT) {
>
> These can be separate so, no else if but just separate if.
>
>
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index ba16248..b1c8d5b 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
>
> > @@ -552,12 +553,12 @@ xfs_showargs(
> > /* Either project or group quotas can be active, not both */
>
> No longer true.
>
> >
> > if (mp->m_qflags & XFS_PQUOTA_ACCT) {
> > - if (mp->m_qflags & XFS_OQUOTA_ENFD)
> > + if (mp->m_qflags & XFS_PQUOTA_ENFD)
> > seq_puts(m, "," MNTOPT_PRJQUOTA);
> > else
> > seq_puts(m, "," MNTOPT_PQUOTANOENF);
> > } else if (mp->m_qflags & XFS_GQUOTA_ACCT) {
>
> Also not else if - just if.
>
> > - if (mp->m_qflags & XFS_OQUOTA_ENFD)
> > + if (mp->m_qflags & XFS_GQUOTA_ENFD)
>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
