On Wed, 2011-10-12 at 09:40 +1100, Dave Chinner wrote: > On Mon, Oct 10, 2011 at 02:22:16PM -0400, Christoph Hellwig wrote: > > This effectively reverts > > > > xfstests: add mapped write fsx operations to 091 > > > > and adds a new test case for it. It tests something slightly different, and > > regressions in existing tests due to new features are pretty nasty in a > > test suite. > > Makes sense. > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Index: xfstests-dev/263 > > =================================================================== > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > > +++ xfstests-dev/263 2011-10-10 18:06:59.000000000 +0000 > > @@ -0,0 +1,64 @@ > > +#! /bin/bash > > +# FS QA Test No. 263 > > +# > > +# fsx exercising direct IO vs sub-block buffered I/O > > +# > > +#----------------------------------------------------------------------- > > +# Copyright (c) 2000-2004 Silicon Graphics, Inc. All Rights Reserved. > > +# > > +# This program is free software; you can redistribute it and/or > > +# modify it under the terms of the GNU General Public License as > > +# published by the Free Software Foundation. > > +# > > +# This program is distributed in the hope that it would be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program; if not, write the Free Software Foundation, > > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > +# > > +#----------------------------------------------------------------------- > > +# > > +# creator > > +owner=nathans@xxxxxxx > > No point keeping an invalid email address as the owner of a new > test. My only comment was that there is some small value in knowing who the original author of the test. > FWIW, I'm considering removing this from the tests as the > information is in the commit history, and the use of the field > (emailing the owner when the automated test infrastructure SGI used > 10 years ago failed) is no longer used... ...but you're right, it would be in the commit history so that's probably sufficient. I have no objection to deleting it from all the tests (and the template). -Alex > Otherwise looks OK. > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
