On Mon, 2011-10-10 at 12:52 -0400, Christoph Hellwig wrote: > plain text document attachment > (xfs-stop-flushing-data-wqs-in-xfs_flush_buftarg) > When we call xfs_flush_buftarg (generally from sync or umount) it already > is too late to flush the data workqueues, as I/O completion is signalled > for them and we are thus already done with the data we would flush here. > > There are places where flushing them might be useful, but the current > sync interface doesn't give us that opportunity. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> This looks fine to me for now but I'm going to review it again in the morning. I'll be testing with it overnight though. -Alex _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs