Re: [PATCH] xfstests: 261: test failures caused by bogus mtab entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-10-06 at 15:49 -0400, Christoph Hellwig wrote:
> > +mtab=/proc/self/mounts
> > +if [ ! -r "${mtab}" ]; then
> > +    mtab=/etc/mtab
> > +    if [ ! -r "${mtab}" ]; then
> > +	echo "warning: proceeding without use of mount table" >&2
> > +    fi
> > +fi
> 
> Just use /proc/self/mounts unconditionally, it's been there for a long
> time.

OK.  I was just following the logic embedded in libxcmd
but I do prefer keeping it simple.

					-Alex
> Otherwise looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>



_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux