On Sun, 2011-09-18 at 16:47 -0400, Christoph Hellwig wrote: > Only read the LSN we need to push to with the ilock held, and then release > it before we do the log force to improve concurrency. > > This also removes the only direct caller of _xfs_trans_commit, thus > allowing it to be merged into the plain xfs_trans_commit again. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. The idea here is that once the transaction is committed (which also sets the LSN to use), everything we need to know about any changes are in the log so there's no need to prevent others from moving on from that point--allowing the inode to (transactionally) change to a new state--while the log gets forced out. Right? Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs