On Wed, 2011-09-28 at 20:59 -0400, Christoph Hellwig wrote: > On Wed, Sep 28, 2011 at 05:57:08AM -0500, Alex Elder wrote: > > In fs_table_insert(), realloc() is called to resize the global > > fs_table. If it fails, it overwrites a previously valid fs_table > > pointer with NULL. > > > > Instead, assign the return value to a local temporary and overwrite > > fs_table only if the realloc() call succeeds. The only defined > > errno value for a realloc() failure is ENOMEM, so return that > > explicitly in the event it fails. > > Looks good. Did you encounter this issue in real life? No, just by inspection. I'm working on fixing a different problem, and to do so I need to rearrange things a bit. Along the way I found a bunch of little annoyances like this one, so I figured I might as well fix them while I'm in there. > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks a lot for the reviews. -Alex _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
