Re: [PATCH 1/3] xfs: improve ioend error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 12, 2011 at 09:40:35AM -0500, Alex Elder wrote:
> On Wed, 2011-08-24 at 01:59 -0400, Christoph Hellwig wrote:
> > Return unwritten extent conversion errors to aio_complete.
> 
> It might have been good to call attention to the fact that
> you were fixing it so ioend->io_error is consistently a
> negative errno value now, thereby making the above change
> possible.

Indeed, freel free to fix up the commit message if you want.

> Are we going to drop the last argument to aio_complete() now?

I don't think anything related to it changed.  The argument is passed
on directly to userspace, and the usb gadget caller actually sets it.

No idea what the point of it is.

> Anyway, this looks good, and as you privately requested
> I will commit this patch without waiting for resolution
> of issues in the other two in this series.

The other two in this series are postponed - this one just happened to
be in the series because I found the issues while working on the other
two.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux