On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote: > Most of the allocation functions take the offset length and block > number as parameters for allocation. often they are modified so are > passed by reference. Make the version in the bmalloca structure the > primary version and stop passing them around individually. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Lots of this patch is simply renaming xfs_bmalloca fields "off" -> "offset", "rval" -> "blkno", and "alen" -> "length". Those are very much appreciated changes. I know there are already a lot of patches in this series but it would have been easier to see the "real" change had that part been pulled out as a trivial extra one. But it looks good, anyway. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs