Re: [PATCH 09/25] xfs: do not use xfs_bmap_add_extent for adding delalloc extents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote: 
> We can just call xfs_bmap_add_extent_hole_delay directly to add a delayed
> allocated regions to the extent tree, instead of going through all the
> complexities of xfs_bmap_add_extent that aren't needed for this simple
> case.

Looks good.

By the way, while looking at this I noticed the code in xfs_bunmapi()
seemed to be doing arithmetic with a possibly null br_startblock,
which can't be right...  (In assigning sum just after wasdel gets
assigned.)

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>



_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux