On Wed, 2011-08-24 at 02:04 -0400, Christoph Hellwig wrote: > Both xfs_bmap_add_extent_hole_delay and xfs_bmap_add_extent_hole_real > already contain code to handle the case where there is no extent to > merge with, which is effectively the same as the code duplicated here. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> It looks like an attribute fork will never get a delayed allocation extent assigned to it. At least I assume so, because xfs_bmap_add_extent_hole_delay() only ever works on the data fork. (I didn't know that.) Anyway, it took a bit to get myself into this--no surprise, this is the bmapi code--but assuming the above is true this does produce the same result as before. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
