On Thu, Jul 21, 2011 at 05:05:39PM -0500, Alex Elder wrote: > In xfs_ail_splice(), if a cursor is provided it is updated > to point to the last item on the list to be spliced into > the AIL. But if the AIL was found to be empty, the cursor > (if provided) is just initialized instead. > > There is no reason the null AIL case needs to be any different. > And treating it the same way allows this code to be rearranged > a bit, with a somewhat tidier result. > > Signed-off-by: Alex Elder <aelder@xxxxxxx> I've tested and reviewed the second version of this patch(*) and I don't see anything problems at all, so: Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Cheers, Dave. (*) In saving the second version, I accidentally marked the mail for delete and then forgot to undelete it before switching mail folders and commiting the delete. Hence I'm responding to the first mail :) -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
