On Mon, Jul 25, 2011 at 12:36:58PM -0500, Alex Elder wrote: > I forgot to mention before that I got some > feedback that removing these macros affects > portability to other platforms (BSD specifically). Personally I don't really like the way how the BSD port bolted the XFS buffer use onto the BSD buffer cache. While the BSD buffer cache is quite a bit closer to the original IRIX buffer cache model than the Linux buffer cache, I think trying to reuse it is just as bad an idea as partially using the Linux page cache. Russell might be able to chime in on the current state of the FreeBSD XFS port, but last time I checked it was in a pretty minimal state, thus not even exercising the nasty sides of the buffer cache. If it wants to be full blown it should just adadpt and use the current xfs_buf.c code, which really isn't that Linux specific - sure it uses the Linux memory allocators, shrinkers and the rbtree library, but it's a standalone piece of code with it's own algorithms that have proven to be much better than the existing generic OS buffer caches but catering to the specific XFS needs. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
