On Mon, 2011-07-25 at 12:25 -0400, Christoph Hellwig wrote: > On Mon, Jul 25, 2011 at 10:57:36AM -0500, Alex Elder wrote: > > > Btw, nice follow-on cleanups would be to kill off the xfs_caddr_t and > > > __psint_t/__psunsigned_t types entirely. > > > > Yes. What do you suggest to use for a pointer-sized > > type? Just cast to (long) and rely on the usual arithmetic > > conversions to do the right thing? > > The correct C99 type is (u)intptr_t. In the kernel we only have > uintptr_t, with ACPI defining a local version of intptr_t. I'd suggest > trying to stick to uintptr_t if we can, and if we really need a signed > version add intptr_t to the common headers - it can unconditionally be > typedef to long in Linux anyway. I *knew* there was a standard type but I couldn't remember what it was called. I even scanned through my C spec but gave up looking pretty quickly. I think I had "size" somehow stuck in my mind and that didn't help. -Alex _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
