On Sun, 2011-07-24 at 07:39 -0400, Christoph Hellwig wrote:
> > @@ -1247,6 +1247,7 @@ xlog_bdstrat(
> > {
> > struct xlog_in_core *iclog = bp->b_fspriv;
> >
> > + bp->b_flags &= ~(XBF_FUA|XBF_FLUSH);
>
> I don't think this is correct, we set these before calling into
> xlog_bdstrat, so this means we'll always stip it off after that.
>
> Given that this area is more complicated than the pure macro removal
> how about letting it as-is for now? I have some bigger refactoring
> in this area in my queue, and I'll just incorporate the
> XFS_BUF_ZEROFLAGS into it.
Christoph, are you suggesting that this one hunk just
be excluded from the series? Or the entire patch?
-Alex
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
