On Fri, 2011-07-22 at 16:39 -0700, Chandra Seetharaman wrote: > Remove the definition and usage of the macro XFS_BUF_ZEROFLAGS. > > In the specific contexts, not all flags need to be cleared. Hence the > simplification. > > Rationale for xfs_log.c: > from hch: XBF_READ and XBF_DELWRI will never be set here, XBF_WRITE > XBF_ASYNC, and XBF_SYNCIO are set just below. > Hence clearing only XBF_FUA and XBF_FLUSH would suffice. > > Rationale for xfs_log_recover.c > from hch: XBF_READ, XBF_WRITE, XBF_ASYNC and XBF_DELWRI already get dealt with > in xfs_bwrite a few lines down. > from hch: XBF_SYNCIO, XBF_FUA and XBF_FLUSH are used only in log buffers. No > need to clear them here. Sorry, I reviewed this last week and signed off on it but I see it's stuck in my mail outbox for some reason. Reviewed-by: Alex Elder <aelder@xxxxxxx> > Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx> > --- _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
