On Mon, Jul 18, 2011 at 11:10:03PM -0400, Christoph Hellwig wrote: > I don't really like this very much. Not taking the i_mutex at all > makes the splice_write method in XFS use different locking than > everyone else, and different from the normal XFS write path. > > For example ocfs2 which has the same locking issues just has an > own implementation of the splice_write method, which isn't > too nice but at least marginally better. I think the right > fix for both xfs and ocfs2 would be to have a generic_file_splice_write > variant that takes an "actor" function pointer, which defaults to > a smaller wrapper around file_remove_suid, file_update_time and > splice_from_pipe_feed, and then XFS and ocfs2 can provide their > own actors that add the additional locking. Yeah I thought about doing that, but wanted to try a simpler version first. I'll code up the actor variant. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
