On Mon, Jul 11, 2011 at 05:33:04PM -0500, Alex Elder wrote: > On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote: > > Replace the typeless b_fspriv2 and the ugly macros around it with a properly > > typed transaction pointer. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > So it looks like you do two things. > - make it a real pointer (which it should be), when it's > used to keep track of the transaction a buffer is > associated with; and > - eliminate the use of this field storing cast 1's and 2's > for verifying the way log buffers are used. > > I don't see much value in the second one, and the first > is the way it should be, so this looks good to me. I should have mentioned that it also drops those pointless debug checks in the log code. I'll add it to the patch description. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs