On Wed, 2011-06-29 at 13:33 -0700, Chandra Seetharaman wrote: > On Wed, 2011-06-29 at 02:30 -0400, Christoph Hellwig wrote: > > On Wed, Jun 29, 2011 at 02:46:16PM +1000, Dave Chinner wrote: > > > On Tue, Jun 28, 2011 at 05:53:04PM -0700, Chandra Seetharaman wrote: > > > > Cleanup: Replace bp->flags usage with predefined macros. > > > > > > > > Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx> > > > > > > Christoph can correct me if I'm wrong, but I'm pretty sure his long term > > > direction is to remove the XFS_BUF_* macros completely. > > > > Yes, at least those that are simpler flags get/set/clear wrappers. > > So, the suggestion is to go the other way and remove all the wrappers > and use bp->flags directly ? Yes, that's right. Sorry about that. Chandra asked me for some things to do on XFS so I fired a few small simple odds and ends I had made note of along the way. This was one--I said that the use of macros should be consistent. I said we should eventually do away with them entirely, but I didn't recommend he do that right now since this was being done by a new contributor. Chandra, I think if you're up to it, doing away with the macros is the right way to go. -Alex _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
