On 6/14/11 1:41 PM, Chandra Seetharaman wrote: > Hello, > > test case 244 expects a mkfs option projid32bit, which is not present in > older version of mkfs.xfs(for example 3.1.1 in RHEL 6.1). > > I though of making it a "requires" for this test, so that the test case > doesn't generate a "failure" when the test is run on older versions. > > Opinions ? Yes, that make sense; care to send a patch with proper signoff? Thanks, -Eric > regards > > chandra > > PS: here is the test o/p > > FSTYP -- xfs (non-debug) > PLATFORM -- Linux/x86_64 elm3c201 2.6.39-rc4-xfs.git.p2+ > MKFS_OPTIONS -- -f -bsize=4096 /dev/sdd2 > MOUNT_OPTIONS -- -o context=system_u:object_r:nfs_t:s0 /dev/sdd2 /mnt/xfsScratchMntPt > > 244 [failed, exit status 1] - output mismatch (see 244.out.bad) > --- 244.out 2011-04-20 08:34:36.000000000 -0700 > +++ 244.out.bad 2011-06-14 11:29:57.000000000 -0700 > @@ -1,2 +1,25 @@ > QA output created by 244 > -Silence is golden > +unknown option -i projid32bit=0 > +Usage: mkfs.xfs > +/* blocksize */ [-b log=n|size=num] > +/* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num, > + (sunit=value,swidth=value|su=num,sw=num), > + sectlog=n|sectsize=num > +/* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2] > +/* log subvol */ [-l agnum=n,internal,size=num,logdev=xxx,version=n > + sunit=value|su=num,sectlog=n|sectsize=num, > + lazy-count=0|1] > +/* label */ [-L label (maximum 12 characters)] > +/* naming */ [-n log=n|size=num,version=2|ci] > +/* prototype file */ [-p fname] > +/* quiet */ [-q] > +/* realtime subvol */ [-r extsize=num,size=num,rtdev=xxx] > +/* sectorsize */ [-s log=n|size=num] > +/* version */ [-V] > + devicename > +<devicename> is required unless -d name=xxx is given. > +<num> is xxx (bytes), xxxs (sectors), xxxb (fs blocks), xxxk (xxx KiB), > + xxxm (xxx MiB), xxxg (xxx GiB), xxxt (xxx TiB) or xxxp (xxx PiB). > +<value> is xxx (512 byte blocks). > +mkfs failed > +(see 244.full for details) > Ran: 244 > Failures: 244 > Failed 1 of 1 tests > > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
