On Fri, Jun 10, 2011 at 01:39:47PM -0700, Chandra Seetharaman wrote: > Hi all, > > Test case 202 tries to create a single AG filesystem and runs xfs_repair > on it expecting it to fail. > > But, when I run the test with a filesystem that is bigger than 1TB it > fails (not pleasantly) since the max AG size is 1TB. > > I am thinking of the following solution, please let me know if there is > any other elegant fix. > > chandra > ------------------------ > diff --git a/202 b/202 > index cbdcb57..b871d8b 100755 > --- a/202 > +++ b/202 > @@ -42,10 +42,12 @@ _supported_os Linux > _require_scratch > > echo "== Creating single-AG filesystem ==" > -_scratch_mkfs_xfs -d agcount=1 >/dev/null 2>&1 > +_scratch_mkfs_xfs -d agcount=1 >/dev/null 2>&1 \ > + || _scratch_mkfs_xfs -d agcount=1 -d size=268435455b >/dev/null 2>&1 > + || _fail "!!! failed to make filesystem" Why the second mkfs attempt with a fixed block size? That will still fail for block size > 4k. All you need to do is detect the first attempt failed. > > echo "== Trying to repair it (should fail) ==" > -_scratch_xfs_repair > +_scratch_xfs_repair && _fail "!!! xfs_repair of single AG filesystem > succeeded" This is not necessary - the golden image compare at the end of the test will detect this succeeding when it shoul dbe failing. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
