On Fri, May 20, 2011 at 05:46:19PM -0700, Allison Henderson wrote: > On 5/19/2011 6:22 PM, Allison Henderson wrote: > >Also, there was one more test that I meant to be a part of this > >collection, but I was not finished with it at the time I submitted the > >patch for feedback. Basically it checks to see if a hole can still be > >punched out when the disk is full. In ext4 this is allowable because > >reserved space is used to allow the operation to proceed where it would > >have otherwise failed. I'm not sure if this is also ext4 specific > >though. Would this be another candidate for adding to 252? Thx! > > I just didnt want this question to get washed away in the traffic. > I am working on an updated patch set, should I include the extra > test case? Thx! Yes, though probably not in the _generic_test_punch function. And extra case specific to 252 that does something like: umount SCRATCH_DEV make a small filesystem scratch_mount prealloc to ENOSPC punch Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
