On Wed, 2011-05-04 at 10:44 +1000, Dave Chinner wrote: > On Tue, May 03, 2011 at 03:14:44PM -0500, Alex Elder wrote: > > From: Joe Perches <joe@xxxxxxxxxxx> > > > > xfs_alert_tag() can be defined using xfs_alert(), and thereby avoid > > using xfs_printk() altogether. This is the only remaining use of > > xfs_printk(), so changing it this way means xfs_printk() can simply > > be eliminated.can simply be eliminated.can simply be eliminated.can > > simply be eliminated.can simply be eliminated.can simply be > > eliminated.can simply be eliminated.can simply be eliminated.can > > simply be eliminated. > > > > Also add format checking to the non-debug inline function xfs_debug. > > Miscellaneous function prototype argument alignment. > > > > (Updated to delete the definition of xfs_printk(), which is > > no longer used or needed.) > > > > Signed-off-by: Alex Elder <aelder@xxxxxxx> > > If you are going to credit Joe as the original source of the patch > in the commit (i.e. via the "From:" tag), you probably should copy > in his original Signed-off-by tag as well.... Honestly I wasn't sure about that. Since I changed it I kind of hoped he'd acknowledge or sign off on it. I guess I'm still learning about the conventions for signing off on things. I want to give all credit properly, I just don't always know the Right Way to do so. -Alex _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
