On Thu, Apr 21, 2011 at 04:44:45PM -0500, Alex Elder wrote: > This patch creates a test that exercises xfs_metadump, with a focus > on its obfuscation of names. It was created to verify fixes that > avoided a hang condition when running "xfs_metadump" on a directory > containing files having particular bit patterns in their name. > Arkadiusz MiÅ?kiewicz first reported seeing this while attempting > to create a metadump for a filesystem containing a file named > "R\323\257NE". > > For now this script checks the following (using only filenames, not > attributes): > - that short names (4 characters or less) aren't obfuscated > - that long names get obfuscated > - that (long) directory names get obfuscated > - that names that are known to produce bit patterns that lead > to invalid path components still generate obfuscated names > (this could previously lead to a hang) > - that many names of the same length can still generate new > obfuscated names (this could previously lead to a hang) > - that neither "lost+found" nor orphaned files stored in it ge > obfuscated > > Right now there are two sets of "ls" commands executed (one before > and one after obfuscation). This produces repeatable results for > me on one filesystem, but on a different filesystem I expect the > inode numbers to change (and random number generation might change > the output too). I'm interested in suggestions on how to filter > the output so the results can be verified. If nothing else, the > test serves its purpose if I simply comment out those commands, > and will do that if there's not a better suggstion. Don't put the listing in the golden output - just put it in $seq.full. That way if the test fails, the output is still there for analysis. Otherwise looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
