The patch looks good to me. But I'm a bit worried about the lack of test coverage. As Eric said if you're able to get a metadump of a filesystem that shows this issue it would come in useful for regression testing. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs