On Wed, Apr 06, 2011 at 10:02:57AM -0400, Christoph Hellwig wrote: > On Wed, Apr 06, 2011 at 04:19:18PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > On the Power platform, the log tail debug checks fire excessively > > causing the system to panic early in testing. The debug checks are > > known to be racy, though on x86_64 there is no evidence that they > > trigger at all. > > > > We want to keep the checks active on debug systems to alert us to > > problems with log space accounting, but we need to reduce the impact > > of a racy check on testing on the Power platform. > > > > As a result, convert the ASSERT conditions to warnings, and > > allow them to fire only once per filesystem mount. This will prevent > > false positives from interfering with testing, whilst still > > providing us with the indication that they may be a problem with log > > space accounting should that occur. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Keeping a potentially racy debug check around still seems somewhat > fishy to me. But you've done all the recent log work, so if it's > going to help you spot problems I'm fine with keeping it in this way, It was invaluable when testing the modifications to make the log grant accounting lockless, so I really don't want to get rid of it altogether. This seemed like the least-worst compromise.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
