On Sat, 2011-04-02 at 14:13 -0400, Christoph Hellwig wrote: > For a CONFIG_XFS_DEBUG=n build gcc complains about statements with no > effect in xfs_debug: > > fs/xfs/quota/xfs_qm_syscalls.c: In function 'xfs_qm_scall_trunc_qfiles': > fs/xfs/quota/xfs_qm_syscalls.c:291:3: warning: statement with no effect > > The reason for that is that the various new xfs message functions have a > return value which is never used, and in case of the non-debug build > xfs_debug the macro evaluates to a plain 0 which produces the above > warnings. This can be fixed by turning xfs_debug into an inline function > instead of a macro, but in addition to that I've also changed all the > message helpers to return void as we never use their return values. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> . . . _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
