On Wed, Mar 23, 2011 at 11:03:32AM -0500, Eric Sandeen wrote: > Test 249 was appearing to pass on ext4, but it wasn't really > exercising the test due to lack of "-F" in the xfs_io arguments. > > Without -F the files were created (oddly enough); neither pwrite > nor sendfile were executed, and the diff of the two (empty) > files passed, resulting in a passed test without testing anything. > > So add the -F, capture the output, and test the result of each > xfs_io invocation. Ok. > Also, when it fails, the diff output is huge. Make diff silent, > but describe the diff failure and exit. Excellent - I was going to suggest this myself given you were touching this test. > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
