Re: [PATCH] xfstests: ensure selinux xattrs don't interfere with quota tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-03-18 at 14:30 -0500, Eric Sandeen wrote:
> 219 and 235 were failing on ext3 with selinux, because the extra
> xattrs upped the quota usage.
> 
> Do the same trick we've used in the past to mount with an selinux
> global context when doing quota tests.
> 
> Note the gross hack for remount,ro, though.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

My only suggestion would be to define the value of
the security context using a variable, so it's
easier to see that the thing you're editing out of
/etc/mtab is identical to the thing that was
supplied as a mount option.  I.e., define
    MOUNT_CONTEXT="system_u:object_r:nfs_t:s0"
and use it in the two spots elsewhere.

But even if you don't take that suggestion this
looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux