Re: [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 10, 2011 at 12:35:49PM -0500, Christoph Hellwig wrote:
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> > +STATIC void
> > +xfs_flush_worker(
> > +	struct work_struct *work)
> > +{
> > +	struct xfs_mount *mp = container_of(work,
> > +					struct xfs_mount, m_flush_work);
> > +
> > +	xfs_sync_data(mp, SYNC_TRYLOCK);
> > +	xfs_sync_data(mp, SYNC_TRYLOCK | SYNC_WAIT);
> > +	xfs_log_force(mp, XFS_LOG_SYNC);
> 
> No actually new in this patch: but what's the point of the log force
> here?  xfs_sync_data just did one before returning.

Historical, I think. Removed.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux