On Thu, 2011-03-10 at 12:29 -0500, Christoph Hellwig wrote: > > LIB_SUBDIRS = include lib > > TOOL_SUBDIRS = ltp src m4 > > +ifeq ($(HAVE_DMAPI), true) > > +TOOL_SUBDIRS += dmapi > > +endif > > Does this work with the way we generate source tarballs on make dist? > In xfsprogs we have special variables for source files that don't get > build. > > > @@ -0,0 +1,30 @@ > > +# > > +# Copyright (c) 2011 SGI All Rights Reserved. > > +# > > I think a license would be more useful than all rights reserved here. > > Except for that the patch looks sane to me, and having a consistent > build system is a good thing. Here's the text I'm using, FYI. # # Copyright (C) 2011 SGI All Rights Reserved. # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as # published by the Free Software Foundation; either version 2 of the # License, or (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU # General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA # 02110-1301, USA. # _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
