Re: [PATCH 1/2] xfstests: a few fixes to Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-03-10 at 12:25 -0500, Christoph Hellwig wrote:
> > +ifeq ($(HAVE_DMAPI), true)
> >  	# automake doesn't always support "default" target 
> >  	# so do dmapi make explicitly with "all"
> > -ifeq ($(HAVE_DMAPI), true)
> 
> What about moving the # signs to the first line so that it never gets
> echoed at all?
> 
> Otherwise looks good to me.

That would work too.  A later patch makes the
whole thing go away though, so it's sort of moot.
(And I already committed it after some discussion
with Eric yesterday...)

					-Alex

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux