On Thu, 2011-01-27 at 14:53 +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Commit 368e136 ("xfs: remove duplicate code from dquot reclaim") fails > to unlock the dquot freelist when the number of loop restarts is > exceeded in xfs_qm_dqreclaim_one(). This causes hangs in memory > reclaim. Remove the bogus loop exit check that causes the problem. > > Reported-by: Malcolm Scott <lkml@xxxxxxxxxxx> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Still not a pretty loop (and I have no suggestions to improve it). But it looks correct. Please add a mention in the description that the double-increment issue in the qi_dqlist_lock case has been fixed. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs