Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +typedef	int32_t	atomic_t;
> +typedef	int64_t	atomic64_t;
> +
> +#define atomic_inc_return(x)	(++(*(x)))
> +#define atomic_dec_return(x)	(--(*(x)))
> +
> +#define atomic64_read(x)	*(x)
> +#define atomic64_set(x, v)	(*(x) = v)

These defintions are pretty dangerous if we ever happens to use
them in multi-threaded code like repair.   Currently we're not,
but they should grow a larger warning comment.

> --- /dev/null
> +++ b/include/hlist.h

Why not add the hlist helpers to list.h, like in the kernel tree?

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux