On Tue, Jan 18, 2011 at 11:24:37AM +1100, Dave Chinner wrote: | On Mon, Jan 17, 2011 at 08:37:08AM -0600, Geoffrey Wehrman wrote: | > On Mon, Jan 17, 2011 at 04:18:28PM +1100, Dave Chinner wrote: | > | However, this does not solve the extsize allocation issues where we | > | don't have dirty pages in the page cache covering parts of the | > | delayed allocation extent so we still need a solution for that. I'm | > | tending towards zeroing in .aio_write as the simplest solution | > | because it doesn't cause buffer head/extent tree mapping mismatches, | > | and it would use the above intent/done operations for crash | > | resilience so there's no additional, rarely used code path to test | > | through .writepage. Does that sound reasonable? | > | > Zeroing in .aio_write will create zeroed pages covering the entire | > allocation, correct? | | Yes, though it only needs to zero the regions that the write does | not cover itself - no need to zero what we're about to put data | into. ;) Glad you were able to understand what I meant. Something I didn't think of earlier though: What happens when I try to use an 8 GB on a system with only 4 GB of memory? I'm not really worried about this pathological case, but I do wonder what the effects will be of allocating what could be significant quantities of memory in .aio_write. -- Geoffrey Wehrman 651-683-5496 gwehrman@xxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
