On Wed, 2011-01-12 at 11:35 +1100, Dave Chinner wrote: > This series completely reworks the cmn_err logging infrastructure > by replacing it with a simple, consistent API that can be used everwhere. > IOWs, this series replaces the various cmn_err APIs: . . . I reviewed the whole series, and offered a correction on just one thing. I might quibble with the indentation of some of the format strings here or there, but I didn't bother, there sometimes is no nice way to do those. I personally like the result a lot, it's a lot cleaner and easier on the eyes. In any case, you say it's an RFC but I'm OK with it. I'm just starting to test with it but you can consider the whole series reviewed by me. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
