On Tue, 2011-01-11 at 10:37 +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > The current xfs_file_aio_write code is a mess of locking shenanigans > to handle the different locking requirements of buffered and direct > IO. Start to clean this up by disentangling the direct IO path from > the mess. > > This also removes the failed direct IO fallback path to buffered IO. > XFS handles all direct IO cases without needing to fall back to > buffered IO, so we can safely remove this unused path. This greatly > simplifies the logic and locking needed in the write path. I reviewed this before, and your statement here now explains the important change you made about the dead code for falling back to buffered I/O. So: Reviewed-by: Alex Elder <aelder@xxxxxxx> I think Christoph and I have signed off on all eight of the patches in this series now. -Alex > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > --- _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
