Re: [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 10, 2011 at 02:23:05PM -0500, Christoph Hellwig wrote:
> > -	xfs_ilock(ip, XFS_IOLOCK_EXCL);
> > +	xfs_rw_ilock(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL);
> 
> this now takes i_mutex, which will be taken again by
> generic_file_splice_write.

Ah, oops. I'll revert that bit - I thought we had test coverage of
that interface. I guess we need a basic sanity test for this
functionality. I'll write one.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux