Re: [PATCH] XFS: Compare, don't assign in ASSERT() in xfs_trans_unreserve_and_mod_sb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 25, 2010 at 09:14:53PM +0100, Jesper Juhl wrote:
> Hi,
> 
> In fs/xfs/xfs_trans.c::xfs_trans_unreserve_and_mod_sb() at the out: label 
> we have this:
> 	ASSERT(error = 0);
> I believe a comparison was intended, not an assignment. If I'm right, the 
> patch below fixes that up.

Already fixed in this patch pending for 2.6.38:

http://git.kernel.org/?p=linux/kernel/git/dgc/xfsdev.git;a=commitdiff;h=831ef3cf682a1f9d8fc7c16dace55137751c0410

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux