On Tue, Dec 21, 2010 at 06:28:57PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > The XFS iolock needs to be re-initialised to a new lock class before > it enters reclaim to prevent lockdep false positives. Unfortunately, > this is not sufficient protection as inodes in the XFS_IRECLAIMABLE > state can be recycled and not re-initialised before being reused. > > We need to re-initialise the lock state when transfering out of > XFS_IRECLAIMABLE state to XFS_INEW, but we need to keep the same > class as if the inode was just allocated. Hence we need a specific > lockdep class variable for the iolock so that both initialisations > use the same class. > > While there, add a specific class for inodes in the reclaim state so > that it is easy to tell from lockdep reports what state the inode > was in that generated the report. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> I think I already reviewed this one, but in case it got lost: Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
