Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 13, 2010 at 03:44:32PM +1100, Dave Chinner wrote:
> -		__field(void *, reserve_headq)
> -		__field(void *, write_headq)
> +		__field(void *, reserveq)
> +		__field(void *, writeq)

To repeat my question from the last review:  what's the point in logging
this at all?  There's not much we can do with it from trace-cmd / perf
output.  What might be more useful is a list_empty() boolean flag.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux