On Mon, Dec 13, 2010 at 03:44:35PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> Prepare for switching the grant heads to atomic variables by
> combining the two 32 bit values that make up the grant head into a
> single 64 bit variable. Provide wrapper functions to combine and
> split the grant heads appropriately for calculations and use them as
> necessary.
>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Minor nitpick:
> + if ((tail_cycle == head_cycle) && (head_bytes >= tail_bytes)) {
> + free_bytes = log->l_logsize - (head_bytes - tail_bytes);
> + } else if ((tail_cycle + 1) < head_cycle) {
Lots of superflous braces in the if statements.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
