On Fri, Dec 17, 2010 at 09:15:56AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 13, 2010 at 03:32:22PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> >
> > We now have two copies of AIL insert operations that are mostly
> > duplicate functionality. The single log item updates can be
> > implemented via the bulk updates by turning xfs_trans_ail_update()
> > into a simple wrapper. This removes all the duplicate insert
> > functionality and associated helpers.
>
>
> Looks good,
>
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> > + struct xfs_ail *ailp,
> > +static inline void
> > +xfs_trans_ail_update(
> > + xfs_log_item_t *lip,
> > + xfs_lsn_t lsn) __releases(ailp->xa_lock)
> > +{
> > + struct xfs_log_item *log_items[1] = { lip, };
> > +
> > + xfs_trans_ail_update_bulk(ailp, log_items, 1, lsn);
>
> This could be simplified down to:
>
> xfs_trans_ail_update_bulk(ailp, &lip, 1, lsn);
>
> at which point it could even become a macro.
Yup, good point. Done.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
