> error2 = filemap_write_and_wait_range(mapping, pos, end); > - if (!error) > + if (error2) > error = error2; > if (need_i_mutex) > mutex_lock(&inode->i_mutex); > @@ -777,7 +777,7 @@ write_retry: > > error2 = -xfs_file_fsync(file, > (file->f_flags & __O_SYNC) ? 0 : 1); > - if (!error) > + if (error2 && error >= 0) > error = error2; Shouldn't the filemap_write_and_wait_range clause use a similar check as this one? _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs