Re: [PATCH] xfstests: fix 108 golden output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2010-11-10 at 07:58 -0500, Christoph Hellwig wrote:
> The new common scratch mount filter produces slightly different
> whitespaces than the old home grown filter, so adjust the golden
> output.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I found out why this is happening.  I get no
such error, and Dave Chinner said he wasn't seeing
it either.

xfs_quota is formatting its output such that the
second and later columns always align at a certain
offset from the beginning of the line.  As a result,
path names assigned as SCRATCH_DEV of different
lengths will produce different (filtered) output,
with more or fewer blanks between SCRATCH_DEV and
the usage number.

Boris Ranto has proposed a change that would
add the "-b" flag to diff when checking output
against golden output.  That should fix it, but
it's possible we *want* differences in white
space to matter in some cases.  Have to look
into this.

					-Alex

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux