On Mon, Nov 29, 2010 at 12:38:19PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > The grant write and reserve queues use a roll-your-own double linked > list, so convert it to a standard list_head structure and convert > all the list traversals to use list_for_each_entry(). We can also > get rid of the XLOG_TIC_IN_Q flag as we can use the list_empty() > check to tell if the ticket is in a list or not. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> A minor comment below: > - __field(void *, reserve_headq) > - __field(void *, write_headq) > + __field(void *, reserveq) > + __field(void *, writeq) Not sure why added these to the traces originally, but imho it's pretty pointless. If we care at all we could log a boolean flag if the queues are empty or not. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
