On Tue, Nov 16, 2010 at 12:16:11PM +0100, Jan Kara wrote: > On Mon 15-11-10 12:05:18, Josef Bacik wrote: > > diff --git a/fs/open.c b/fs/open.c > > index 4197b9e..ab8dedf 100644 > > --- a/fs/open.c > > +++ b/fs/open.c > > @@ -223,7 +223,7 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len) > > return -EINVAL; > > > > /* Return error if mode is not supported */ > > - if (mode && !(mode & FALLOC_FL_KEEP_SIZE)) > > + if (mode && (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))) > Why not just: > if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) ? > Good point, thank you. > > diff --git a/include/linux/falloc.h b/include/linux/falloc.h > > index 3c15510..851cba2 100644 > > --- a/include/linux/falloc.h > > +++ b/include/linux/falloc.h > > @@ -2,6 +2,7 @@ > > #define _FALLOC_H_ > > > > #define FALLOC_FL_KEEP_SIZE 0x01 /* default is extend size */ > > +#define FALLOC_FL_PUNCH_HOLE 0X02 /* de-allocates range */ > ^ use lowercase 'x' please... > Argh bitten by caps-lock again. Thanks I'll fix this up, Josef _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
