On Wed, 2010-11-10 at 16:39 -0500, Christoph Hellwig wrote: > In commit 20cb52ebd1b5ca6fa8a5d9b6b1392292f5ca8a45, titled > "xfs: simplify xfs_vm_writepage" I added an assert that any !mapped > and > uptodate buffers are not dirty. That asserts turns out to trigger a > lot > when running fsx on filesystems with small block sizes. The reason > for > that is that the assert is simply incorrect. !mapped and uptodate > just mean this buffer covers a hole, and whenever we do a > set_page_dirty > we mark all blocks in the page dirty, no matter if they have data or > not. So remove the assert, and update the comment above the condition > to match reality. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
