Re: [PATCH 2/4] xfstests: add _require_attrs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-10-21 at 01:02 -0400, Christoph Hellwig wrote:
> On Wed, Oct 20, 2010 at 01:03:11PM -0500, Alex Elder wrote:
> > On Fri, 2010-10-15 at 18:29 -0400, Christoph Hellwig wrote:
> > > Add a new helper to check if extended attributes are supported.  It
> > > errors out if any of the attr tools are not found, or if a filesystem
> > > does not support setting attributes.
> > > 
> > > Remove the opencoded checks for the attr tools from various tests
> > > now that we do them in common code.
> > 
> > Generally this looks good.
> > 
> > I was going to just make a few suggestions and ask you
> > to fix them before committing, but  I think there are
> > enough that I think it would be good to re-submit this.
> 
> I'd rather commit the patch as-is and fix up the attr/getfattr
> references separately.  I'll submit a patch to do ASAP.
> 

Sounds good to me.  Probably better that way anyway.	-Alex

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux