On Fri, 2010-10-15 at 18:29 -0400, Christoph Hellwig wrote:
> Do a _notrun in 225 if we get EOPNOSUPP back from FIEMAP instead
> of failing the test.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good, but I think if the operation is not
supported you want to delete both "${fiemapfile}"
and "${fiemaplog}".
While you're at it, make use of the "${fiemapfile}"
variable in the fiemap-tester command... (This
appears to be a bug in the original test.)
Reviewed-by: Alex Elder <aelder@xxxxxxx>
> --- a/225
> +++ b/225
> @@ -49,13 +49,19 @@ _supported_os Linux
> _setup_testdir
>
> fiemapfile=$TEST_DIR/fiemap.$$
> +fiemaplog=$TEST_DIR/fiemap.$$.log
>
> [ -x $here/src/fiemap-tester ] || _notrun "fiemap-tester not built"
>
> echo "fiemap run without preallocation"
> -$here/src/fiemap-tester -q -p 0 -r 200 $TEST_DIR/fiemapfile
> +$here/src/fiemap-tester -q -p 0 -r 200 $TEST_DIR/fiemapfile 2>&1 | tee $fiemaplog
> +
> +if grep -q "Operation not supported" $fiemaplog; then
> + _notrun "FIEMAP not supported by this filesystem type: $FSTYP"
> +fi
>
> rm -f $fiemapfile
> +rm -f $fiemaplog
> rm -f $seq.full
>
> status=0
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
