On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote: > > This looks good to me but I'd like a second opinion, > > to make sure there's no reason any of these should > > be non-executable. > > I don't think it matters. Consistency is good, though, and we've > taken patches like this in the past. Yeah. Btw, I'm not sure git-am can apply the mode changes from a patch, in the worst case you might have to do the chmod calls manually. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs